Skip to content

Commit

Permalink
remove defunct perform event TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
Owen Shepherd committed Apr 7, 2020
1 parent b0939d5 commit 6904992
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/Reflex/PerformEvent/Base.hs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
(result0, requests0) <- lift $ runA a0
newA <- requestingIdentity $ runA <$> a'
requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA
--TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
RequesterInternalT $ tellEvent requests
pure (result0, fmapCheap fst newA)
{-# INLINE traverseIntMapWithKeyWithAdjust #-}
Expand All @@ -109,7 +108,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
results' = fmap fst <$> children'
requests' = fmap snd `fmapCheap` children'
requests <- switchHoldPromptOnlyIncremental mergeIntIncremental coincidencePatchIntMap requests0 requests'
--TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatIntMapMaybe
pure (results0, results')
{-# INLINE traverseDMapWithKeyWithAdjust #-}
Expand All @@ -125,7 +123,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
results' = mapPatchDMap (snd . getCompose) <$> children'
requests' = weakenPatchDMapWith (fst . getCompose) `fmapCheap` children'
requests <- switchHoldPromptOnlyIncremental mergeMapIncremental coincidencePatchMap requests0 requests'
--TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
pure (results0, results')
{-# INLINE traverseDMapWithKeyWithAdjustWithMove #-}
Expand All @@ -141,7 +138,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
results' = mapPatchDMapWithMove (snd . getCompose) <$> children'
requests' = weakenPatchDMapWithMoveWith (fst . getCompose) `fmapCheap` children'
requests <- switchHoldPromptOnlyIncremental mergeMapIncrementalWithMove coincidencePatchMapWithMove requests0 requests'
--TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
pure (results0, results')

Expand Down

0 comments on commit 6904992

Please sign in to comment.