-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate MALDIquant's baseline estimation #119 #120
Conversation
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
The GHA fails - I have tried to fiddle with it, so just ignore the workflow file for now. (Or any advise welcome) |
General points to consider for this review:
|
In addition to using simulated example data, I also export the individual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lgatto for integrating the baseline estimation algorithms!
I just changed some values for the iteration/half window sizes to demonstrate the difference in the simulated data.
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Co-authored-by: Sebastian Gibb <mail@sebastiangibb.de>
Thank you @sgibb! |
Addresses #119