GUI in separate thread (fix #189) #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am afraid with this threading. We should use coroutines or Futures from reactive programming. Let it hang until we decide... |
|
see #255 |
| """ Builds srpm into base directory. """ | ||
| print('Building SRPM...') |
There was a problem hiding this comment.
use logging instead of prints, please
| @@ -222,9 +222,11 @@ def write_spec(self): | |||
|
|
|||
| def build_srpm(self): | |||
| """ Builds srpm into base directory. """ | |||
| print('Building SRPM...') | |||
There was a problem hiding this comment.
use logging.info instead, please.
|
@PavolVican be a QA and test this manually from GUI, please |
|
We did a demo but it fails on #376 Look at it @regeciovad, please. |
|
This is not a fix of bug #376, I still didn't find where is the problem. But hawkey build fails in my computer even in master branch so it is not about this pull request. If I find solution, maybe I will create new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.