-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo manifest (dependencies and formatting) + dependabot #748
Update cargo manifest (dependencies and formatting) + dependabot #748
Conversation
I realized afterward that is use features higher than MSRV (1.61.0). The required version would be 1.64. |
I'd try to avoid excessive formatting changes... that makes it difficult to tell where the changes actually reside. Also, I see some changes to |
I bumped |
Actually, I have found the minimum versions that compile and run tests successfully: [dependencies]
smallvec = { version = "1.7.0", default-features = false, features = ["union", "const_new", "const_generics"] }
ahash = { version = "0.8.2", default-features = false, features = ["compile-time-rng"] }
num-traits = { version = "0.2.0", default-features = false }
once_cell = { version = "1.7.0", default-features = false, features = ["race"] }
bitflags = { version = "2.0.0", default-features = false }
smartstring = { version = "1.0.0", default-features = false }
rhai_codegen = { version = "1.5.0", path = "codegen", default-features = false }
no-std-compat = { git = "https://gitlab.com/jD91mZM2/no-std-compat", version = "0.4.1", default-features = false, features = ["alloc"], optional = true }
libm = { version = "0.2.0", default-features = false, optional = true }
hashbrown = { version = "0.13.1", optional = true }
core-error = { version = "0.0.0", default-features = false, features = ["alloc"], optional = true }
serde = { version = "1.0.96", default-features = false, features = ["derive", "alloc"], optional = true }
serde_json = { version = "1.0.45", default-features = false, features = ["alloc"], optional = true }
unicode-xid = { version = "0.2.0", default-features = false, optional = true }
rust_decimal = { version = "1.16.0", default-features = false, features = ["maths"], optional = true }
getrandom = { version = "0.2.0", optional = true }
rustyline = { version = "11.0.0", optional = true }
document-features = { version = "0.2.0", optional = true }
[dev-dependencies]
rmp-serde = "1.1.0"
serde_json = { version = "1.0.45", default-features = false, features = ["alloc"] } |
I would much rather set a minimum workable version, and let the user bump to higher if he/she wants. |
@Mathieu-Lala why don't I do this: I'll update |
Sure! Sorry I didn't have time to complete and fix this PR. |
Closing this for now, as the new version will adhere to recommended style by citing the minimum versions of dependencies. |
Summary of changes
Changed
Cargo.toml
s, specify the compete version of the dependencies (see this article)Cargo.toml
s, use theworkspace
notation when relevantdefault-features = false
and list the features usedsyn
to>=2
, and update the implementation accordinglypackage.edition
to2021
Style
Cargo.toml
s files usingnot yet merged rustfmt
, especially this.Fixed
#[default] enum variants
Added