Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS v2, add more manual cleanups #47

Merged
merged 26 commits into from
Nov 17, 2023
Merged

Use AWS v2, add more manual cleanups #47

merged 26 commits into from
Nov 17, 2023

Conversation

fridim
Copy link
Contributor

@fridim fridim commented Nov 16, 2023

  • Use AWS v2 CLI, less dependency hell and has latest features.
  • Add manual cleanup:
    • for multi-region access points
    • for vpc-lattice target groups
    • for FSx filesystems, virtual machines, and volumes, see https://aws.amazon.com/fsx/
    • Directory Service:
      • Unregister Workspaces from Directory Service
    • Deactivate any MFA device from users
  • aws-nuke config: Ignore KSMAlias alias/eks/*
  • ignore protected config-rule-role -> config-rule-policy

The full traceback is:
Traceback (most recent call last):
  File "/home/opentlc-mgr/pool_management/python_virtualenv/lib64/python3.9/site-packages/ansible/executor/task_executor.py", line 105, in run
    items = self._get_loop_items()
  File "/home/opentlc-mgr/pool_management/python_virtualenv/lib64/python3.9/site-packages/ansible/executor/task_executor.py", line 251, in _get_loop_items
    items = templar.template(self._task.loop)
  File "/home/opentlc-mgr/pool_management/python_virtualenv/lib64/python3.9/site-packages/ansible/template/__init__.py", line 612, in template
    result = self.do_template(
  File "/home/opentlc-mgr/pool_management/python_virtualenv/lib64/python3.9/site-packages/ansible/template/__init__.py", line 877, in do_template
    res = j2_concat(rf)
  File "<template>", line 24, in root
  File "/usr/lib64/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
fatal: [localhost]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
@fridim fridim requested a review from rut31337 November 16, 2023 20:33
error:

            "us-east-2 - FSxFileSystem - fs-06cc090bdfcf8a221 - [Type: \"ONTAP\", tag:Name: \"OntapFileSystem_SAZ\", tag:aws:cloudformation:logical-id: \"FSxONTAP\", tag:aws:cloudformation:stack-id: \"arn:aws:cloudformation:us-east-2:26135
6917804:stack/ROSA-FSXONTAP/b38f3d30-7ff8-11ee-8326-067f114c23f1\", tag:aws:cloudformation:stack-name: \"ROSA-FSXONTAP\"] - failed"
@fridim fridim changed the title Use AWS v2 + delete multi-region access points Use AWS v2, add more manual cleanups Nov 17, 2023
@fridim fridim merged commit 9cd4f58 into main Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants