Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disasm, if first instruction is at a map boundary. #4718

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Nov 14, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

If the first instruction lies at a memory map boundary, it wasn't disassembled. Because the attempted to disassemble at addr - 4 failed. This is fixed by starting decdoing at the memory/buffer boundary.

Test plan

Added

Closing issues

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant