fix(commons): deduplicate logic to keep behavior consistent [#14] #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detailed in (#14)
Expected behavior
Detailed in (#14)
Remediations
The
__contains__
logic also needed to be fixed to allow the simplification in this commit. Checkinghasattr
wasn't a limiting enough condition, as anything in the class dictionary would also returnTrue
. This led to errors when using namespaces as modules, because they'd take in attribute names like__doc__
which would proc aPermissionError
in frozen classes.This that the frozen functionality is consistently applied across the various interfaces & class hierarchies.
aiootp/tests/test_namespace_classes.py
Lines 307 to 321 in 70cd055
Resolution related to (#9, #11, #14)