Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove supervision version block #788

Closed
wants to merge 1 commit into from

Conversation

onuralpszr
Copy link
Contributor

Description

Hello 👋 It is simple fix for removing version block so that we can install supervision latest always.

Current version Inference causes issues in colab or various test cases it rollback version of supervision and make harder to test
@grzegorz-roboflow
Copy link
Contributor

Might be risky when there are features staged for obsolesce in supervision, @PawelPeczek-Roboflow what's your opinion?

@onuralpszr
Copy link
Contributor Author

onuralpszr commented Nov 8, 2024

Might be risky when there are features staged for obsolesce in supervision, @PawelPeczek-Roboflow what's your opinion?

Well, I can understand that but everytime I tried to install supervision + inference I got errors or rollback to older version of sv. Also If supervision parts needs to be update I can help those (I didn't check tests so I don't how extensive they are) but at least supervision and inference should align IMO.

@grzegorz-roboflow
Copy link
Contributor

It's more to do with the fact that some folks may be stuck with older versions of inference due to other dependencies they have - at least I think we might introduce problems hard to predict if we remove version pin, I might be too paranoid, lets hear @PawelPeczek-Roboflow opinion

Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual control is required due to planned removals that happen in supervision over time - I am fine to bump to newest version if everything works, but not to remove the pin

@PawelPeczek-Roboflow
Copy link
Collaborator

closing in favour of PR I am just preparing with bumping up the versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants