Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curving Road #538

Merged
merged 11 commits into from
Jul 8, 2024
Merged

Add Curving Road #538

merged 11 commits into from
Jul 8, 2024

Conversation

Seren-35
Copy link
Contributor

Source: http://inabapuzzle.com/honkaku/curving.html

In edit mode, I made circle placement follow the same behavior as shaded cells in dynasty genres, since two circles can never be adjacent in a solvable puzzle, whereas circles one empty cell apart seem to be a common pattern in puzzles I've seen.

When checking for paths that turn only once, at most one erroneous path per circle is highlighted. There can be quadratically many of those in total so highlighting all of them in sufficiently wrong answers can easily cover most of the grid and turn it unreadable. This seemed like a good compromise.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pzprjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 7:50am

@x-sheep x-sheep self-requested a review June 20, 2024 20:24
@x-sheep x-sheep added the new genre For requesting or implementing new puzzle genres label Jun 20, 2024
Copy link
Collaborator

@x-sheep x-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I like how the error highlighting looks.

src/pzpr/variety.js Outdated Show resolved Hide resolved
src/variety/kabingurodo.js Outdated Show resolved Hide resolved
test/script/kabingurodo.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@x-sheep x-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. I'm going to release San-Anko on monday, and this genre 2 weeks after.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.17%. Comparing base (714f14f) to head (0cd0f60).
Report is 7 commits behind head on main.

Files Patch % Lines
src/variety/curving.js 96.29% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   91.16%   91.17%   +0.01%     
==========================================
  Files         190      192       +2     
  Lines       20976    21097     +121     
==========================================
+ Hits        19122    19236     +114     
- Misses       1854     1861       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@x-sheep x-sheep merged commit 83b740a into robx:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new genre For requesting or implementing new puzzle genres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants