Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextjs module #1628

Merged

Conversation

ParfenenkovEdit
Copy link
Collaborator

Title of Pull Request

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview:
  • Implementation Approach:

Additional Information

  • Screenshots/Links:
  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@ParfenenkovEdit ParfenenkovEdit changed the title Nextjs module [WIP] Nextjs module May 1, 2024
Copy link
Collaborator

@kravaring kravaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
Just a few minor comments.

react/modules/tasks/nextjs-ssr-ssg.md Outdated Show resolved Hide resolved
react/modules/nextjs-ssr-ssg/README.md Outdated Show resolved Hide resolved
react/modules/tasks/nextjs-ssr-ssg.md Show resolved Hide resolved
react/modules/tasks/nextjs-ssr-ssg.md Show resolved Hide resolved
react/modules/tasks/nextjs-ssr-ssg.md Outdated Show resolved Hide resolved
react/modules/tasks/nextjs-ssr-ssg.md Outdated Show resolved Hide resolved
react/modules/tasks/nextjs-ssr-ssg.md Outdated Show resolved Hide resolved
@ParfenenkovEdit ParfenenkovEdit changed the title [WIP] Nextjs module Nextjs module May 19, 2024
@kravaring kravaring merged commit 3899e25 into rolling-scopes-school:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants