Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Train-A project #1683

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Added Train-A project #1683

merged 3 commits into from
Aug 13, 2024

Conversation

OlehDulebaEpam
Copy link
Collaborator

New final project: Train-A

Added .md files along with images to the project Train-A in tasks

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview:
    New project composed to orchestrate train journeys as manager and consume as a user.
  • Implementation Approach:
    Project requires Angular framework, libraries for components and styles.

Additional Information

  • Screenshots/Links:
result-route
  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@lyutails
Copy link
Collaborator

lyutails commented Aug 8, 2024

hey there o/

isn't the final project lasts for three (3) weeks :?

image

image

and maybe worth adding info in readme about submitting task for cross-check to ## Assessment e.g. :)


#### Acceptance Criteria 3: Modal window content (5)

- Title of modal contains text "Route" alogn with route id number.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in 'alogn' should be along :)

- The "Admin" link must redirect to the [admin page](./admin/readme.md).
- The "Admin" link must be accessible only to users with the manager or administrator role, enforced by a guard.

#### Acceptance Criteria 4: Guard for qdmin page
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little typo here :) 'qdmin' should be 'admin'


#### Requirement 2: Guest state

- The header must display the following links for guests:
Copy link
Collaborator

@lyutails lyutails Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit confusing ':' at the end of the line :)
maybe to add smth like you can find details in the ### Acceptance Criteria


#### Requirement 3: General user state

- The header must display the following links for authenticated general users:
Copy link
Collaborator

@lyutails lyutails Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit confusing ':' at the end of the line :)
maybe to add smth like you can find details in the ### Acceptance Criteria


- **Name record:** Name of the user.
- **Email record:** Registered user email.
- **Eedit buttons:** Pencil buttons to allow user edit information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly should be 'Edit' instead of 'Eedit' :)

- **Form field _Date_**: From what date to search
- **Search**: Button to initiate the search process
- **Result list item**:
- **Arrival date/time**: When train reach the target
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should be reaches here


> [!WARNING]
> **Technical quirk**
> Developer should obtain coordinates of the location throught whatever external services their want while user fill city name in the form field.
Copy link
Collaborator

@lyutails lyutails Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little typo :)
throught probably should be through
and maybe their want > they want
and probably user fills


> [!WARNING]
> **Technical quirk**
> Developer should obtain coordinates of the location throught whatever external services their want while user fill city name in the form field.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably same typos here
throught probably should be through
and maybe their want > they want
and probably user fills

@OlehDulebaEpam OlehDulebaEpam merged commit cd38b51 into master Aug 13, 2024
1 check passed
@OlehDulebaEpam OlehDulebaEpam deleted the task/train-a-2 branch August 13, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants