Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mshv-bindings: implement send for svm_ghcb_base #178

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

russell-islam
Copy link
Collaborator

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@russell-islam russell-islam changed the title mshv-bindings: implement send/sync for svm_ghcb_base mshv-bindings: implement send for svm_ghcb_base Nov 12, 2024
Signed-off-by: Muminul Islam <muislam@microsoft.com>
Copy link
Member

@liuw liuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The send in the subject line should be Send, since it is a well-known trait's name.

@russell-islam russell-islam merged commit 37771ac into main Nov 13, 2024
6 checks passed
@russell-islam russell-islam deleted the muislam/send-sync-svm-base branch November 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants