Clean up repo #39
Clean up repo #39
Conversation
You need to make releases https://github.com/saabi/vminpoly/releases
I also condensed all the scripts into one importable script. If someone is using a custom CSS tokenizer/parser and don’t want to use the one bundled with this, they can still access a clean version of vminpoly.js from src folder.
TODO stuff should be opened as new Issues
|
I've added a few notes on the commit messages for how to keep stuff kinda organized. Let me know if you have any questions. Leave a comment here if you don't intend to merge this any time soon or whatever, and I'll maintain a fork. |
|
Oh, and your demos should probably go into But one thing at a time! |
|
Hey, thanks for all the work! I'll review your changes and merge the request as soon as I have some time, which should be this week. |
|
@saabi No problem. I reviewed it just now and left a few notes. I'm super lazy about redoing commits but if you wanna create a release first then merge this I can tweak it and submit a new PR before you |
|
@corysimmons I'm still pressed for time but I added you as a collaborator to the repo if it'll help you to move ahead with your PRs. There are other PRs from other users, but as far as how to go about those I advise caution because some modifications are on the parser code which belongs to @tabatkins CSS Parser repo. His code has evolved considerably since I used it for vminpoly and I think the proper thing to do is to eventually update this repo to use the latest CSS parsing code. So any changes to his code on this repo runs the risk of getting lost during such an upgrade. Let me know what you think. |
|
Sounds good. I'll try to get everything merged in and cleaned up and encourage the PR maintainers to rebase their PRs. I don't have a huge interest in maintaining functionality changes to this polyfill but I'm happy to clean up the repo. ;) |
|
@corysimmons Yes, please do merge and clean this up. That would be great. New to GitHub and repos but if I can help somehow let me know. Quite like that as really viewport-sized typography is really it and who knows in the future there might be better browser support, fingers crossed. |
|
Has this pull request managed to get merged with master yet? |
|
I don't think so. |
Before you merge this, you should create a new release tagged
0.1.0.After you merge this, you should create a new release tagged
0.1.1.