feat: Added select/deselect all notes button #1377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edgiest05
changed the title
Edgiest05
changed the title
|
Same functionality is now available also in each directory of the browse page |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 47.39% 47.23% -0.17%
==========================================
Files 114 115 +1
Lines 8959 8992 +33
==========================================
+ Hits 4246 4247 +1
- Misses 4713 4745 +32 ☔ View full report in Codecov by Sentry. |
Edgiest05
force-pushed
the
feat-select-all
branch
from
620a0dc
to
56797dd
Compare
|
Resolved merge conflicts and updated |
Edgiest05
force-pushed
the
feat-select-all
branch
from
56797dd
to
020b8af
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
020b8af
to
99080d2
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
99080d2
to
b8aa4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced button in recent page footer that allows for selection of all notes
When less than all files are selected
When all files have already been selected, behaviour changes to unselect all
While implementing this I had to address that newer version of the
saver_gallerydependency would not compile.Furthermore
preview_cardmakes use of a different variableexpandedwhen it actually should never differ from thewidget.selectedone (or else some selection changes do not reflect in the UI). I've kept it for consistency's sake.