Merge pull request #1414 from tgodzik/fix-doctor

bugfix: Don't run command without clicking and fix infinite recursion
scalameta · Aug 7, 2023 · 9ccd390 · 9ccd390
2 parents edc446c + caffc12
commit 9ccd390
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/packages/metals-vscode/src/extension.ts b/packages/metals-vscode/src/extension.ts
@@ -569,9 +569,9 @@ function launchMetals(
         commands.executeCommand(workbenchCommands.focusDiagnostics)
       );
 
-      registerCommand(ClientCommands.RunDoctor, () =>
-        commands.executeCommand(ClientCommands.RunDoctor)
-      );
+      registerCommand(ClientCommands.RunDoctor, async () => {
+        await doctorProvider.runDoctor();
+      });
 
       registerCommand(ClientCommands.ToggleLogs, () => {
         if (channelOpen) {
@@ -722,13 +722,7 @@ function launchMetals(
             item.tooltip = params.tooltip;
           }
           if (params.command) {
-            const command = params.command;
             item.command = params.command;
-            commands.getCommands().then((values) => {
-              if (values.includes(command)) {
-                commands.executeCommand(command);
-              }
-            });
           } else {
             item.command = undefined;
           }