Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: add jdk indexing #6481

Merged
merged 2 commits into from
Jun 20, 2024
Merged

improvement: add jdk indexing #6481

merged 2 commits into from
Jun 20, 2024

Conversation

kasiaMarek
Copy link
Contributor

resolves: #6304

@kasiaMarek kasiaMarek force-pushed the jdk-indexing branch 2 times, most recently from 2cc51b3 to 0dea7f6 Compare June 5, 2024 13:06
@kasiaMarek kasiaMarek requested a review from tgodzik June 14, 2024 09:26
tgodzik
tgodzik approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this should be really useful. The only question is whether it works if user uses multiple JDKs on one machine?

metals/src/main/scala/scala/meta/internal/metals/SqlSharedIndices.scala Outdated
class SqlSharedIndices
extends H2ConnectionProvider(
() => AbsolutePath(Paths.get(sys.props("user.home"))).resolve(".metals"),
"metals-shared",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you used names parameters? Would be useful to see what are these strings used for.

@kasiaMarek
Copy link
Contributor Author

The only question is whether it works if user uses multiple JDKs on one machine?

Why wouldn't it work? Jars are identified by md5 that is calculated on the path, size and last modified attribute. And we always get information out for specific jar (identified by the path).

@tgodzik
Copy link
Contributor

tgodzik commented Jun 20, 2024

The only question is whether it works if user uses multiple JDKs on one machine?

Why wouldn't it work? Jars are identified by md5 that is calculated on the path, size and last modified attribute. And we always get information out for specific jar (identified by the path).

Just making sure 😅 We could later add the same for Scala jars

@kasiaMarek kasiaMarek requested a review from tgodzik June 20, 2024 10:38
tgodzik
tgodzik approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@kasiaMarek kasiaMarek merged commit ad29a25 into scalameta:main Jun 20, 2024
22 of 24 checks passed
@untainsYD untainsYD mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index type hierarchy for JDK
2 participants
@kasiaMarek @tgodzik