fix: prefer latter fully qualified name parts when building trigrams for fuzzy search #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
i6475
branch
3 times, most recently
from
e21a048
to
3a3d49a
Compare
tgodzik
reviewed
Jun 6, 2024
| @@ -1277,7 +1277,6 @@ class AutoImplementAbstractMembersSuite extends BaseCodeActionSuite { | |||
| | | |||
| |trait Base: | |||
| | def foo(x: Int): Int | |||
| | def bar(x: String): String | |||
There was a problem hiding this comment.
Because the ordering doesn't seem to be stable (or somehow this PR changed it for 3.3.1, though it really doesn't seem related). I can probably sort but for this example it doesn't matter if there is more than one method.
There was a problem hiding this comment.
it would be good though to have them implemented the same way they are in the parent trait. I can imagine people complaining if this is not the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #6475