-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serial-buildorder
argument for the tree-of
subcommand
#419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primeos-work
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it LGTM but a few details aren't right yet.
tested successfully :) thx! |
christophprokop
added
the
prerelease
PRs which are merged to staging branch but not in main/master
label
Oct 1, 2024
- Introduced a new command-line argument `--serial-buildorder` that outputs the flattened package DAG in a serial build order. - The `--serial-buildorder` argument conflicts with the existing `--dot` argument for now. Showing the serial build order in the dot format would not bring any benefits. - Ensured cyclic dependency detection and error handling during topological sorting. Fixes science-computing#379 Signed-off-by: Nico Steinle <nico.steinle@eviden.com>
primeos-work
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
primeos-work
changed the title
Add
Add Nov 5, 2024
serial-buildorder
argument to the build-treeserial-buildorder
argument for the tree-of
subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--serial-buildorder
thatoutputs the flattened package DAG in a serial build order.
--serial-buildorder
argument conflicts with the existing--dot
argument for now. Showing the serial build order in the dot format
would not bring any benefits.
topological sorting.
Fixes #379