Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial-buildorder argument for the tree-of subcommand #419

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ammernico
Copy link
Collaborator

@ammernico ammernico commented Sep 12, 2024

  • Introduced a new command-line argument --serial-buildorder that
    outputs the flattened package DAG in a serial build order.
  • The --serial-buildorder argument conflicts with the existing --dot
    argument for now. Showing the serial build order in the dot format
    would not bring any benefits.
  • Ensured cyclic dependency detection and error handling during
    topological sorting.

Fixes #379

Copy link
Member

@primeos-work primeos-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM but a few details aren't right yet.

src/cli.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Show resolved Hide resolved
src/commands/tree_of.rs Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
@christophprokop
Copy link
Collaborator

tested successfully :) thx!

@christophprokop christophprokop added the prerelease PRs which are merged to staging branch but not in main/master label Oct 1, 2024
- Introduced a new command-line argument `--serial-buildorder` that
  outputs the flattened package DAG in a serial build order.
- The `--serial-buildorder` argument conflicts with the existing `--dot`
  argument for now. Showing the serial build order in the dot format
  would not bring any benefits.
- Ensured cyclic dependency detection and error handling during
  topological sorting.

Fixes science-computing#379

Signed-off-by: Nico Steinle <nico.steinle@eviden.com>
Copy link
Member

@primeos-work primeos-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@primeos-work primeos-work changed the title Add serial-buildorder argument to the build-tree Add serial-buildorder argument for the tree-of subcommand Nov 5, 2024
@primeos-work primeos-work added this pull request to the merge queue Nov 5, 2024
Merged via the queue into science-computing:master with commit b2e96b9 Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease PRs which are merged to staging branch but not in main/master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

butido tree-of --serial-buildorder
3 participants