Allow per item validators to be specified by string

scrapinghub · Sep 13, 2023 · 6c1a7d8 · 6c1a7d8
1 parent 6edb037
commit 6c1a7d8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/docs/source/item-validation.rst b/docs/source/item-validation.rst
@@ -141,6 +141,17 @@ as a `dict`:
         OtherItem: '/path/to/otheritem_schema.json',
     }
 
+Keys of `dict` can also be strings matching item class names:
+
+.. code-block:: python
+
+    SPIDERMON_VALIDATION_SCHEMAS = {
+        'DummyItem': '/path/to/dummyitem_schema.json',
+        'OtherItem': '/path/to/otheritem_schema.json',
+    }
+
+
+
 Validation in Monitors
 ----------------------
 

diff --git a/spidermon/contrib/scrapy/pipelines.py b/spidermon/contrib/scrapy/pipelines.py
@@ -56,7 +56,7 @@ def set_validators(loader, schema):
             if type(schema) in (list, tuple):
                 schema = {Item: schema}
             for obj, paths in schema.items():
-                key = obj.__name__
+                key = obj if type(obj) in (str) else obj.__name__
                 paths = paths if type(paths) in (list, tuple) else [paths]
                 objects = [loader(v) for v in paths]
                 validators[key].extend(objects)

diff --git a/tests/contrib/scrapy/test_pipelines.py b/tests/contrib/scrapy/test_pipelines.py
@@ -203,6 +203,16 @@ class PipelineJSONSchemaValidator(PipelineTest):
                 assert_type_in_stats(TreeItem),
             ],
         ),
+        DataTest(
+            name="validators specified by str rather than class",
+            item=TreeItem(),
+            settings={SETTING_SCHEMAS: {"TestItem": test_schema, "TreeItem": tree_schema}},
+            cases=[
+                f"{{stats}}['{STATS_MISSINGS}'] is 1",
+                assert_type_in_stats(TestItem),
+                assert_type_in_stats(TreeItem),
+            ],
+        ),
     ]