Adds limit for nested dict stats computation #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @mrwbarg |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 79.39% 79.42% +0.03%
==========================================
Files 76 76
Lines 3222 3228 +6
Branches 534 536 +2
==========================================
+ Hits 2558 2564 +6
Misses 593 593
Partials 71 71 ☔ View full report in Codecov by Sentry. |
|
@Gallaecio @rennerocha could you check on this PR? It's ready to be reviewed. |
Gallaecio
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
It is OK by me. However, I wonder if we should consider making the default -1 for no-limit, and make 0 cause this:
'spidermon_item_scraped_count/dict': 2
'spidermon_item_scraped_count/dict/field1': 2
'spidermon_item_scraped_count/dict/field2': 2
'spidermon_item_scraped_count/dict/field3': 1
'spidermon_item_scraped_count/dict/field4': 1
|
Can we close this in favor of #433 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416
Adds a setting to limit how deep the coverage is computed for nested dicts.