Allow spider attr #235
Open
Allow spider attr #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed process_html (render response in html feature) from this PR * removed remote request tests with extra spider
* refactors tests from functions to objects inheriting from unittest.TestCase * adds tests for enabling middleware with spider attribute
This reverts commit bed8998. T#
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 92.67% 92.74% +0.07%
==========================================
Files 9 9
Lines 587 593 +6
Branches 118 119 +1
==========================================
+ Hits 544 550 +6
Misses 21 21
Partials 22 22
Continue to review full report at Codecov.
|
Gallaecio
force-pushed
the
allow_spider_attr
branch
from
f8fb2fb
to
47f162d
Compare
Gallaecio
force-pushed
the
allow_spider_attr
branch
from
47f162d
to
40961cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #15.
Related to #11, although since it works at the spider level, not at a wider, project level, I wouldn’t say it fixes it.