fix: rearrange so assert(false) not on return path #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyasiddharth
commented
Nov 2, 2022
lib/seadsa/Graph.cc
Outdated
| if (m_links.count(omni)) return *m_links.at(omni); | ||
|
|
||
| assert(false); // unreachable | ||
| assert(m_links.count(omni)); |
There was a problem hiding this comment.
this change is important
There was a problem hiding this comment.
the diff is too confusing. You are replacing a return with assert. That cannot be correct.
There was a problem hiding this comment.
The earlier code was
if (m_links.count(omni)) return *m_links.at(omni)
// else fall through to
assert(false)
// ** possibly undefined return value depending on semantics of assert **
// ** Thus, compiler complains.
Now it is rewritten such that intent is clearer and we pass the compiler check
assert(m_links.count(omni))
// ** possibly incorrect return value if assert is nop. However, **
// ** based on existing logic, we expect the assert to never fail **
return *m_links.at(omni)
lib/seadsa/RemovePtrToInt.cc
Outdated
| ptr, {I.getOperand(1)}); | ||
| auto *gep = | ||
| IRB.CreateGEP(ptr->getType()->getScalarType()->getPointerElementType(), | ||
| ptr, I.getOperand(1)); |
There was a problem hiding this comment.
important: braces around scalar initializer removed
priyasiddharth
force-pushed
the
dev14
branch
from
2687495
to
aaaa30e
Compare
priyasiddharth
force-pushed
the
dev14
branch
from
aaaa30e
to
8eabd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other changes are format only