Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize number of goroutine to avoid excessive resource usage #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shahariaazam
Copy link
Member

@shahariaazam shahariaazam commented Apr 7, 2023

Implemented worker pool size. Now with discovery.worker_pool_size you can control how many goroutine can be created to fetch resources to avoid system load.

Closes #27

@shahariaazam shahariaazam linked an issue Apr 7, 2023 that may be closed by this pull request
@shahariaazam shahariaazam self-assigned this Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (7d30877) 75.27% compared to head (dded2fc) 75.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   75.27%   75.37%   +0.10%     
==========================================
  Files          15       15              
  Lines        1181     1186       +5     
==========================================
+ Hits          889      894       +5     
  Misses        252      252              
  Partials       40       40              
Impacted Files Coverage Δ
pkg/processor/processor.go 94.00% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

…of-goroutine-to-avoid-excessive-resource-usage

# Conflicts:
#	pkg/config/config_test.go
#	pkg/config/testdata/valid_config.yaml
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize number of goroutine to avoid excessive resource usage
1 participant