mvp: first pre-release #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from credly initial build
…to exclude modified the filterdata func to filter out expird certs and uses a helper function for date comparison
trying to optimise by reducing allocations
users can passing filename via cli, default behaviour still sends data to stdout unless flags are provided
…of updating content of files(new and existing
* test: Validate dat parser works as expected * chore: Update go mod * refactor: Added some standard errors for uniformity inerror handling * test: Add a few variations of different dateformats * docs: Add comments to exported Errors * refactor: Improved the parameter validation slightly to accept returning multiple params * fix: Scrap this test as it breaks CI and doesn't do anything
* refactor: Refactored the file writer to implement the io.Writer interface for testing * test: Added some tests for the file writer * fix: Added a helper/decorator closer to return the error in a defer * fix: Fix unsafe path return error reported in CI * refactor: Renamed the parameter name to avoid collision with the filepath package
shanilhirani
force-pushed
the
feat/intial-build
branch
from
3426bbc
to
e89e0dd
Compare
Codecov ReportAttention: Patch coverage is
|
some badges do not have expiry dates therefore API response contains a null value, nested if should handle by adding a zero value for the expected data type
|
merging despite of codecov failing - this will be addressed later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.