API Stop refering to "pages" when dealing with generic records #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
from
3e495f0
to
456360d
Compare
This was referenced Oct 17, 2024
Draft
Draft
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
from
456360d
to
87954c0
Compare
GuySartorelli
commented
Oct 17, 2024
| CMSMain::class . '.ACCESS', | ||
| LeftAndMain::class . '.ACCESS', |
There was a problem hiding this comment.
CMSMain doesn't even exist if you're installing silverstripe/admin without silverstripe/cms. LeftAndMain is the obvious choice here.
GuySartorelli
commented
Oct 17, 2024
| 'category' => _t(Permission::class . '.CMS_ACCESS_CATEGORY', 'CMS Access'), | ||
| 'category' => _t(LeftAndMain::class . '.CMS_ACCESS_CATEGORY', 'CMS Access'), |
There was a problem hiding this comment.
This belongs on LeftAndMain as it goes hand-in-hand with the one above.
This was referenced Oct 17, 2024
Draft
Draft
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
2 times, most recently
from
db0f381
to
b5d9ce4
Compare
GuySartorelli
commented
Oct 21, 2024
| $abstractClasses = [LeftAndMain::class, CMSMain::class]; | ||
| $abstractClasses = [LeftAndMain::class]; |
There was a problem hiding this comment.
This change is needed so that CMSMain can be included in the left menu and have its route built.
Without this, it was the CMSPagesController which was a very-nearly-useless subclass of CMSMain that was used.
That class has been merged into CMSMain so we need its menu item back
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
from
b5d9ce4
to
3103f12
Compare
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
from
3103f12
to
e3a2ec7
Compare
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
2 times, most recently
from
60b2bda
to
555907c
Compare
GuySartorelli
force-pushed
the
pulls/3/generic-cmsmain
branch
from
555907c
to
c59d3ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here:
LeftAndMain. Found this because I had to review all i18n strings inCMSMainanyway.DataObjectclass, and adds a newgetModelClass()method toLeftAndMain(standardises that method betweenModelAdminandCMSMainand will be used extensively in the follow-up refactor cards in this epic)Issue
SiteTreeinCMSMainsilverstripe-cms#2947