Skip to content

Commit

Permalink
Merge pull request #3002 from kinglozzer/2455-fields-preventing-publish
Browse files Browse the repository at this point in the history
FIX: Remove legacy fields which prevent page publish (fixes #2455)
  • Loading branch information
GuySartorelli authored Sep 12, 2024
2 parents 1dab090 + 42f72f5 commit c77a4c9
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion code/Model/SiteTree.php
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,15 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
"Stage", "Live"
];

/**
* Fields which, if changed on their own, won't cause a new version/live record to be created
* @var string[]
*/
private static array $fields_ignored_by_versioning = [
'HasBrokenFile',
'HasBrokenLink',
];

private static $default_sort = "\"Sort\"";

/**
Expand Down Expand Up @@ -1692,7 +1701,7 @@ protected function onBeforeWrite()
}

// Check to see if we've only altered fields that shouldn't affect versioning
$fieldsIgnoredByVersioning = ['HasBrokenLink', 'Status', 'HasBrokenFile', 'ToDo', 'VersionID', 'SaveCount'];
$fieldsIgnoredByVersioning = $this->config()->get('fields_ignored_by_versioning') ?? [];
$changedFields = array_keys($this->getChangedFields(true, 2) ?? []);

// This more rigorous check is inline with the test that write() does to decide whether or not to write to the
Expand Down

0 comments on commit c77a4c9

Please sign in to comment.