Merge pull request #366 from creative-commoners/pulls/3/new-admincont…

…roller API Update method signature to match parent class
silverstripe · Oct 20, 2024 · df327e2 · df327e2
2 parents 46fbfe4 + c13c127
commit df327e2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/_config.php b/_config.php
diff --git a/src/Controllers/CMSPageHistoryViewerController.php b/src/Controllers/CMSPageHistoryViewerController.php
@@ -27,6 +27,8 @@ class CMSPageHistoryViewerController extends CMSMain
 
     private static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 
+    private static $ignore_menuitem = true;
+
     public function getEditForm($id = null, $fields = null)
     {
         $record = $this->getRecord($id ?: $this->currentPageID());

diff --git a/src/Controllers/HistoryViewerController.php b/src/Controllers/HistoryViewerController.php
@@ -42,6 +42,8 @@ class HistoryViewerController extends LeftAndMain
 
     private static $required_permission_codes = 'CMS_ACCESS_CMSMain';
 
+    private static $ignore_menuitem = true;
+
     private static array $url_handlers = [
         'GET api/read' => 'apiRead',
         'POST api/revert' => 'apiRevert',
@@ -65,7 +67,7 @@ class HistoryViewerController extends LeftAndMain
     /**
      * Returns configuration required by the client app
      */
-    public function getClientConfig()
+    public function getClientConfig(): array
     {
         $clientConfig = parent::getClientConfig();
         foreach ($this->formNames as $formName) {