Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse Via and add via_branch to custom header #491

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

silver0511
Copy link

@silver0511 silver0511 commented Feb 7, 2022

roadmap

Please put the via branch to the custom headers. It's not "must have" value

hi i have moved via branch to custome header, please check and review, thanks

hi i have uploaded two videos to show the transaction features. the first is a call with multiple session. the second is a call with complex sips. (idea from: https://thanhloi2603.wordpress.com/2017/04/22/understanding-sip-transaction-and-dialog/ )

20220301_145904_edit.mp4
20220301_154423_edit.mp4

feature_transaction pr:
homer-app: sipcapture/homer-app#474
homer-ui: sipcapture/homer-ui#584

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2022

CLA assistant check
All committers have signed the CLA.

@adubovikov
Copy link
Member

Please put the via branch to the custom headers. It's not "must have" value

@silver0511 silver0511 changed the title parse Via and add via_branch to protocol_header parse Via and add via_branch to custom header Feb 24, 2022
@silver0511
Copy link
Author

Please put the via branch to the custom headers. It's not "must have" value

@adubovikov hi, i have uploaded two videos to show the transaction features, thanks

@adubovikov
Copy link
Member

@silver0511 did you make the PR for UI ?

@silver0511
Copy link
Author

@silver0511 did you make the PR for UI ?

@adubovikov i will make the pr for ui, homer-app together as soon as possible, thanks

@silver0511
Copy link
Author

@silver0511 did you make the PR for UI ?

@adubovikov hi, i have maked pr for homer-app(sipcapture/homer-app#474) and homer-ui(sipcapture/homer-ui#584), thanks

@silver0511
Copy link
Author

@silver0511 did you make the PR for UI ?

@adubovikov hi, i have maked pr for homer-app(sipcapture/homer-app#474) and homer-ui(sipcapture/homer-ui#584), thanks

@adubovikov hello

@lmangani
Copy link
Member

@silver0511 thanks for your PR, you know we appreciate it but unfortunately its a difficult time. we're going to review and adapt your changes as soon as viable for our team

@silver0511
Copy link
Author

@lmangani Thanks for your recognition, i will always cooperate with you to adjust, fighting!!! :)

@silver0511 silver0511 closed this Jun 7, 2022
@silver0511 silver0511 reopened this Jun 7, 2022
@silver0511
Copy link
Author

@silver0511 thanks for your PR, you know we appreciate it but unfortunately its a difficult time. we're going to review and adapt your changes as soon as viable for our team

@lmangani hi, is everything getting better now :)

@silver0511
Copy link
Author

@adubovikov hi adubovikov, need your help :)

@lmangani
Copy link
Member

lmangani commented Aug 9, 2023

@silver0511 apologies for this incubating so long! I don't want you to think it was not appreciated!
We're now working on the next HOMER version and will make sure this change finds its final destination.

@silver0511
Copy link
Author

@lmangani thanks for your reply, and i found new interesting feature in heplify and commited pull request, i really hope it‘s useful for you :)

@lmangani
Copy link
Member

@silver0511 the direction we're going with the project is headless and all about telemetry. If we could simply emit the transaction record as a Loki log, we would pretty much need nothing else in order to use it in HOMER 10 and Grafana already.

The change in heplify-server to send logs would be sufficient as there are no ui and api components.

@silver0511
Copy link
Author

silver0511 commented Sep 5, 2023

@lmangani hi, it means I need to migrate this feature to logs page?

@lmangani
Copy link
Member

lmangani commented Sep 5, 2023

@silver0511 that's one way to do it, but not necessarily the only one. Are you familiar with our latest homer 10 preview? https://github.com/sipcapture/homer-docker

Basically as long as a type emitted towards the Loki receiver is generated, this would work out of the box. You can use a log type if you want no restrictions, but make sure the body can be parsed with logfmt or json, etc

@silver0511
Copy link
Author

@silver0511 that's one way to do it, but not necessarily the only one. Are you familiar with our latest homer 10 preview?

@lmangani not yet, we are currently focusing on the development of homer 7 :)

@silver0511 silver0511 closed this Sep 5, 2023
@silver0511 silver0511 reopened this Sep 5, 2023
@silver0511
Copy link
Author

@silver0511 that's one way to do it, but not necessarily the only one. Are you familiar with our latest homer 10 preview? https://github.com/sipcapture/homer-docker

Basically as long as a type emitted towards the Loki receiver is generated, this would work out of the box. You can use a log type if you want no restrictions, but make sure the body can be parsed with logfmt or json, etc

i see, but now we are using this feature in the visual interface, which is very helpful for us,by the way, is there a big difference between homer 10 an 7

@lmangani
Copy link
Member

lmangani commented Sep 5, 2023

Less moving parts. There's no custom UI in HOMER 10 everything is done in grafana with a Flow plugin for HEP and using Loki, Prometheus and Tempo for logs, metrics and traces respectively. You can run our demo to check out the new experience we're building including the flow display.

@silver0511
Copy link
Author

thanks, i will try it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants