Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active states to top-level nav menu items #909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1ockwood
Copy link

Changes

This is a fairly simple change that adds active states to the top-level nav menu items on large viewports. As a new user, the first time I clicked around, I expected to see that sort of feedback to give a sense of where I am in the app.

I kept it to the "desktop" version of the nav menu only, as the "mobile" menu is structured a bit differently (the top-level "Bookmarks" item being grouped at the same hierarchy as the other Bookmarks entries), and I don't necessarily feel it needs the same feedback in that context. Happy to experiment with that though if you feel otherwise.

In the same vein, I also tweaked the styles for hover states for the nav menu links.

Screenshots

Dark Mode

nav-menu-active-items-dark

nav-menu-active-items-dark.mov

Light Mode

nav-menu-active-items-light

nav-menu-active-items-light.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant