Add active states to top-level nav menu items #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a fairly simple change that adds active states to the top-level nav menu items on large viewports. As a new user, the first time I clicked around, I expected to see that sort of feedback to give a sense of where I am in the app.
I kept it to the "desktop" version of the nav menu only, as the "mobile" menu is structured a bit differently (the top-level "Bookmarks" item being grouped at the same hierarchy as the other Bookmarks entries), and I don't necessarily feel it needs the same feedback in that context. Happy to experiment with that though if you feel otherwise.
In the same vein, I also tweaked the styles for hover states for the nav menu links.
Screenshots
Dark Mode
nav-menu-active-items-dark.mov
Light Mode
nav-menu-active-items-light.mov