Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/user registration #13

Merged
merged 9 commits into from
Jan 8, 2020
Merged

Feature/user registration #13

merged 9 commits into from
Jan 8, 2020

Conversation

sjeguedes
Copy link
Owner

@sjeguedes sjeguedes commented Jan 8, 2020

This branch creates registration and update profile forms process (new account, account activation and profile avatar / infos update).
This merge aims at testing better workflow with development and features branches added to master. No issue is referenced for this pull request.

This branch treated expected changes and "fixed" issue: #8

  • Added user registration action with email process to activate an account with personal link

  • Added user profile update separated in two forms (avatar and infos management)

  • Enabled ajax mode process to update an avatar

  • Added avatar JavaScript crop process (with cropper.js) in modal to get crop JSON data

  • Added avatar crop and resize (as expected in media type) process on server side

  • Added a lot of JavaScript to improve UI on application

  • Improved form handlers globally in project

These pages need to be tested to limit possible bugs, despite the use of xdebug on branch.
Entities constructors improvements remain partially necessary.

Message: please accept this merge and be conscious multiple changes will be made later.

…dded also on all forms) - prepared files for registration form validation without avatar which will be treated on profile page.
…mation email - added user account activation process.
…need to add ACL or voters to control user profile page access, image crop and resize with AJAX and image optimization - need to improve domain entities PHP classes - need to check possible regressions.
…ascade option for image and media relationship to simplify entities persistence - improved UX when an unchanged form is submitted with particular info flash message to distinct this case with success one, by adding user event combined with form subscriber and custom data mapper.
… in pre submit event. This is made for improved UX when an unchanged update form is submitted with particular info flash message to distinct this case with success one - reformatted files with space after all commas where it is necessary.
…cess denied exception in update profile action
…d resized avatar and other infos separately - enabled ajax mode for avatar management combined to crop process
@sjeguedes sjeguedes merged commit dfd1639 into develop Jan 8, 2020
@sjeguedes
Copy link
Owner Author

sjeguedes commented Jan 8, 2020

Merge accepted!

Please note that:

Entities constructors must be reviewed partially to strengthen them quickly (asserts and data check).
Caution: composer.json file has to be updated to upgrade Symfony from 4.2.12 to version 4.3/4.4 to reach a LTS one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant