Removed bootstrap.native #2876
Merged
Removed bootstrap.native #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Není dořešené obecné volání handlu. Je to testovací řešení. |
added 5 commits
October 18, 2024 15:05
add handle to dialog control
…parented of the Dialog class.
|
Všechny dialogy v aplikaci musí nově dědit od třidy AccountancyModule/Components/Dialog.php |
|
@marekdedic Zatím jsem neměl prostor proklikat celou aplikaci. Vzdělávačky jsem neviděl vůbec. Můžeš to prosím proletět? |
marekdedic
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Ještě jsem to neproklikal, ale zatím jsem našel tyhle věci:
- [nit] Některé soubory nekončí newline, viz tady v diffu
- Je potřeba odebrat výjimku pro updaty v
.github/dependabot.yml, viz Removed bootstrap.native #2875 - Je potřeba odstranit obsolete typy v
frontend/types/bootstrap.native/, viz Removed bootstrap.native #2875
|
Tak jsem to proklikal a lehce kouknul na kód a až na ty 3 věci mi to přijde dobrý. Díky! |
|
Upravil jsem nastavení pro dependabot a odebral ten jeden soubor. Nevím kde by měli být newline. |
|
Díky, jestli prošel coding-standard, tak v poho, za mě dobrý, dík! |
marekdedic
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2874