[cert-v2] punchy-respond on an address in common with the querying host #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackDoanRivian
commented
Oct 28, 2024
JackDoanRivian
commented
Nov 1, 2024
| if ok { | ||
| whereToPunch = newDest | ||
| } else { | ||
| //TODO this means the destination will have no addresses in common with the punch-ee |
There was a problem hiding this comment.
settle this before merge
JackDoanRivian
changed the title
JackDoan
force-pushed
the
cert-v2-punchy4
branch
from
92444fd
to
f4c320c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.