Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reestablish relays when last hop fails #1270

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Reestablish relays when last hop fails #1270

merged 7 commits into from
Nov 15, 2024

Conversation

brad-defined
Copy link
Collaborator

Relays can break and never recover if, with the following setup:
I<->R<->C
the R<->C connection breaks, and the only traffic in the network is I<->C, not C->I.

This change updates host deletion work to mark associated relays as 'Disestablished', because we can't quite tell if they are still working or not. When host I finds its relayed connection is in this state, it will now re-send CreateRelayRequest messages to ensure the end-to-end relayed connection.

Relay host behavior was also updated. Before, the Relay host would use the State status of relay peers to immediately return a CreateRelayResponse if the next hop is already in an Established state. This PR changes the Relay to always forward CreateRelayRequest messages along the path, and only terminal relay peers will generate the CreateRelayResponse message flow.

@johnmaguire
Copy link
Collaborator

As an FYI for viewers, a log line like this at the Lighthouse is indicative of this issue:

Nov 11 16:10:12 linux.dsrgthyz.com nebula[1147]: time="2024-11-11T16:10:12Z" level=info msg="Failed to find target host info by ip" certName=android error="unable to find host with relay" localIndex=2672096877 relayTo=192.168.100.3 remoteIndex=442491203 vpnIp=192.168.100.6
Nov 11 16:10:13 linux.dsrgthyz.com nebula[1147]: time="2024-11-11T16:10:13Z" level=info msg="Failed to find target host info by ip" certName=android error="unable to find host with relay" localIndex=2672096877 relayTo=192.168.100.3 remoteIndex=442491203 vpnIp=192.168.100.6
Nov 11 16:10:14 linux.dsrgthyz.com nebula[1147]: time="2024-11-11T16:10:14Z" level=info msg="Failed to find target host info by ip" certName=android error="unable to find host with relay" localIndex=2672096877 relayTo=192.168.100.3 remoteIndex=442491203 vpnIp=192.168.100.6

Copy link
Collaborator

@nbrownus nbrownus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to backport to v1.9 as well

@nbrownus nbrownus merged commit 21a117a into cert-v2 Nov 15, 2024
9 checks passed
@nbrownus nbrownus deleted the reestablish-relays branch November 15, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants