Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unfreezing CodeLens if auto_submit is set to false #161

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

alashchev17
Copy link
Contributor

Previously, if codelens instructions were containing flag auto_submit set to false - all other intents to click on codelens were prevented.

This pull request provides a fix of that unexpected behavior.

How to test?

  • Step 1: Set codelens instructions to auto_submit: false, new_tab: false
  • Step 2: Try to click Explain first
  • Step 3: Try to click Find Problems then

Expected Result:
Text within textarea should be replaced by text of the instruction itself, codelens should not be frozen anymore.

@alashchev17 alashchev17 self-assigned this Oct 24, 2024
@olegklimov olegklimov deleted the branch dev October 29, 2024 13:32
@olegklimov olegklimov closed this Oct 29, 2024
@alashchev17 alashchev17 reopened this Oct 29, 2024
Copy link
Contributor

@MarcMcIntosh MarcMcIntosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works :)

@alashchev17 alashchev17 merged commit 507de89 into dev Oct 30, 2024
12 checks passed
@alashchev17 alashchev17 deleted the fix/codelens-auto-submit-freeze branch October 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants