Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 0 RPS profiles #1362

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

allow 0 RPS profiles #1362

wants to merge 1 commit into from

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Nov 20, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce various updates and improvements across the library, addressing both functionality and validation aspects. Notably, adjustments have been made to ensure that segments can start with zero RPS, enhancing flexibility in defining load schedules. Additionally, the updates refine input validation and error handling, contributing to the robustness and reliability of the library. These improvements collectively enhance the library's utility and user experience.

What

  • wasp/examples/go.mod:

    • Added a local replacement for github.com/smartcontractkit/chainlink-testing-framework/wasp to facilitate modular development.
    • Updated dependencies to newer versions, improving compatibility and potentially incorporating bug fixes and new features from these libraries.
    • Introduced new indirect dependencies, likely as a consequence of updating direct dependencies, ensuring the project aligns with the dependencies' requirements.
  • wasp/examples/go.sum:

    • Updated module checksums corresponding to the new versions of dependencies specified in go.mod, maintaining the integrity and consistency of the module’s dependencies.
  • wasp/schedule.go:

    • Introduced validation to prevent the creation of steps schedules with zero steps, enhancing error handling and configuration validation.
    • Added a default value for the from parameter in the Steps function, ensuring the schedule starts with a sensible default if an initial value isn't provided.
  • wasp/wasp.go:

    • Implemented a check to pause the generator if the current segment's From value is zero, catering to scenarios where no load should be generated temporarily.
    • Added a safety check to prevent the generator from resuming if the From value is zero, ensuring the generator's state accurately reflects the intended load schedule.
  • wasp/wasp_test.go:

    • Modified and added tests to cover the new validation logic and behavior for schedules starting with zero RPS, ensuring the changes work as intended and maintain the library's reliability.

These changes collectively aim to enhance the library's flexibility, reliability, and user experience by improving configuration validation, error handling, and dependency management.

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant