chore: add/remove linters for consistency #102
Merged
+85
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the linters to be consistent with DPA standards.
jkongie
commented
Nov 20, 2024
| @@ -3,46 +3,75 @@ run: | |||
| tests: false | |||
| modules-download-mode: readonly | |||
| linters: | |||
| disable-all: true | |||
There was a problem hiding this comment.
This was not removed in this PR because the only linter this ends up disabling is the unused linter.
There are a number of functions that are unused and I don't want to remove them unnecessarily.
jkongie
commented
Nov 20, 2024
| - makezero | ||
| - misspell | ||
| # - mnd |
There was a problem hiding this comment.
Quite a few magic numbers exist, so this can be captured in another PR
jkongie
commented
Nov 20, 2024
| - predeclared | ||
| - promlinter | ||
| - staticcheck | ||
| - reassign | ||
| # - revive |
There was a problem hiding this comment.
This is a large lint, so better done in a separate PR
jkongie
commented
Nov 20, 2024
| "github.com/spf13/cobra" | ||
| "github.com/spf13/viper" | ||
|
|
||
| "github.com/smartcontractkit/timelock-worker/pkg/logger" |
There was a problem hiding this comment.
Fixes import ordering
jkongie
commented
Nov 20, 2024
Comment on lines
-45
to
-48
| func (s *integrationTestSuite) Run(name string, subtestFunc func(t *testing.T)) bool { | ||
| return s.T().Run(name, subtestFunc) | ||
| } | ||
|
|
There was a problem hiding this comment.
This didn't seem to be needed but please correct me if there was a reason to wrap this
jkongie
commented
Nov 20, 2024
| @@ -80,9 +76,10 @@ func (s *integrationTestSuite) DeployTimelock( | |||
|
|
|||
| receipt, err := bind.WaitMined(ctx, client, transaction) | |||
| s.Require().NoError(err) | |||
| s.Require().Equal(receipt.Status, types.ReceiptStatusSuccessful) | |||
There was a problem hiding this comment.
Incorrect ordering
gustavogama-cll
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the linters to be consistent with DPA standards.