Weird I/O type switch -- probably unnecessary

smoynes · Feb 13, 2024 · 0145989 · 0145989
1 parent 8ac7dfe
commit 0145989
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/internal/vm/devices_test.go b/internal/vm/devices_test.go
@@ -66,7 +66,7 @@ func TestKeyboardDriver(tt *testing.T) {
 
 	if got, err := reader.Read(addr); err != nil {
 		t.Errorf("read error: %s: %s", addr, err)
-	} else if got & Word(KeyboardEnable|KeyboardReady) != Word(KeyboardEnable) {
+	} else if got&Word(KeyboardEnable|KeyboardReady) != Word(KeyboardEnable) {
 		t.Errorf("expected status ready: want: %s, got: %s", KeyboardEnable, got)
 	}
 

diff --git a/internal/vm/io.go b/internal/vm/io.go
@@ -167,8 +167,10 @@ func (mmio MMIO) KBDR() Word {
 	kbdr := Word('⍝')
 
 	if dev := mmio.devs[KBDRAddr]; dev != nil {
-		val := dev.(*Keyboard)
-		kbdr = Word(val.KBDR)
+		switch dev := dev.(type) {
+		case *Keyboard:
+			kbdr = Word(dev.KBDR)
+		}
 	}
 
 	return kbdr
@@ -179,8 +181,10 @@ func (mmio MMIO) KBSR() Word {
 	kbsr := Word('⍝')
 
 	if dev := mmio.devs[KBSRAddr]; dev != nil {
-		val := dev.(*Keyboard)
-		kbsr = Word(val.KBSR)
+		switch dev := dev.(type) {
+		case *Keyboard:
+			kbsr = Word(dev.KBSR)
+		}
 	}
 
 	return kbsr