feat: create a new snyk view [IDE-711][IDE-712][IDE-713] #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
9083c23
to
e31bd11
Compare
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
e21aa41
to
07ecfa0
Compare
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
07ecfa0
to
5fc6f71
Compare
| try { | ||
| boolean cliFound = getCliFile().exists(); | ||
| boolean tokenFound = !Preferences.getInstance().getAuthToken().isBlank() | ||
| || System.getenv().containsKey("SNYK_TOKEN"); |
There was a problem hiding this comment.
The SNYK_TOKEN check is old and a bug :)
There was a problem hiding this comment.
Should we remove tokenFound, or only the System.getenv().containsKey check?
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootObject.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootObject.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/EnableCodeProductHandler.java
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
27789d2
to
e027045
Compare
...c/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/EnableCodeProductHandler.java
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
def77c5
to
8d3a3c0
Compare
acke
force-pushed
the
feat/IDE-711_create_a_new_snyk_view
branch
from
e17fecf
to
a460b03
Compare
bastiandoetsch
requested changes
Nov 14, 2024
acke
changed the title
acke
changed the title
…m-IaC,-Open-Source-and-Code,-using-a-local-cache (#215) * chore: wip * fix: add info nodes for no issues found and no fixable issues found * fix: tests * feat: add initial tree filling impl * feat: display info nodes * feat: add generic filter method to cache * feat: show view when scanning
bastiandoetsch
changed the title
…s/expand treeviewer.
chore: UI cleanup [IDE-711 ]
Feat/fixable issues filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!