Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spark_data_source.py with configuration param #1884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update spark_data_source.py with configuration param #1884

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7a1d77
Update spark_data_source.py with configuration param
Clusiv Jun 5, 2023
74dfad7
Merge branch 'main' into hive-configuration
Clusiv Jun 5, 2023
b9a3d0d
Merge branch 'main' into hive-configuration
Clusiv Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions soda/spark/soda/data_sources/spark_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ def hive_connection_function(
port: str,
database: str,
auth_method: str,
configuration: dict,
**kwargs,
):
"""
Expand Down Expand Up @@ -59,6 +60,7 @@ def hive_connection_function(
port=port,
database=database,
auth=auth_method,
configuration=configuration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use kwargs instead? Otherwise it will break other connection functions

)
return connection

Expand Down Expand Up @@ -469,6 +471,7 @@ def connect(self):
organization=self.organization,
cluster=self.cluster,
server_side_parameters=self.server_side_parameters,
configuration=self.configuration,
)

self.connection = connection
Expand Down