Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance scan script, split execute to smaller functions. #1978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

duynguyenhoang
Copy link

Hello Soda team!

We are evaluating and adapting Soda as our main data quality tool. This is our first PR.

What include in the PR:

  • Split execute function to smaller functions. It also helps us to write test easier.
  • Allow us to calculate metrics value only without running validation. It is quite useful for us to do dry-run before actually validate data.

Signed-off-by: Duy Nguyen <nhduy88@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@m1n0
Copy link
Contributor

m1n0 commented Jan 26, 2024

Hi! Thanks for the contribution! Could you please explain in a bit more detail how exactly this helps you? I get the split, but I would appreciate a bit more context and possibly a bit more thought into designing the split, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants