HOSTPAD driver changes for PAC #91
Conversation
|
Below are the associated PRs for this functionality. #88 HLD PR is below we will raise the remaining functionality in new PRs asap. |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
|
@jeff-yin @ridahanif96 pls help review |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
Ali Hussain from xFlow will review these PRs |
| fprintf(stderr, "socket failed [%s]\n", strerror(errno)); | ||
| return -1; | ||
| } | ||
| printf("Created a socket with fd: %d\n", fd); |
There was a problem hiding this comment.
Do we need printfs in this function?
| /* Let us initialize the server address structure */ | ||
| saddr.sin_family = AF_INET; | ||
| saddr.sin_port = htons(3434); | ||
| local_host = gethostbyname("127.0.0.1"); |
There was a problem hiding this comment.
I'm guessing this local socket is for the communication between "hostapd" & "pacd" applications,
My question is why have we not leveraged/added logic to the control interface that is exposed by hostapd via lib_wpaclient
https://gist.github.com/sepfy/25c1a34e9b418de230a1d97c56de88a6
There was a problem hiding this comment.
The control interface uses synchronous communication. The PAC uses the control interface to send command updates etc. In case of asynchronous data reception such as information retrieved from the radius response etc , PAC listens on a server socket. Hence this change.
Why I did it
These changes are required to support PAC functionality to sonic-wpasupplicant driver.
How I did it
How to verify it