Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DarkSky (RIP) weather provider #40

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Remove DarkSky (RIP) weather provider #40

merged 1 commit into from
Nov 2, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Jan 7, 2023

Per Dark Sky's blog, the API will continue to work "until March 31st, 2023." The next release after that should include this patch to remove the no-longer-functional provider.

Copy link

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me, RIP

@dgw
Copy link
Member Author

dgw commented Jan 8, 2023

NB: #41 should fix the Actions failure.

@dgw
Copy link
Member Author

dgw commented Jan 27, 2023

Rebased after merge of #41; CI works now. Time to set a reminder for April 1?

@dgw
Copy link
Member Author

dgw commented Jan 28, 2023

Rebased again as merge of #43 caused conflicts. (I knew it would, tbf.)

@dgw dgw mentioned this pull request Mar 26, 2023
@dgw
Copy link
Member Author

dgw commented Nov 2, 2023

Rebased as long as I was working on #47.

@RustyBower RustyBower merged commit 37d33a1 into master Nov 2, 2023
4 checks passed
@RustyBower RustyBower deleted the rip-darksky branch November 2, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants