Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subscription-service): add billing functionality to subscription… #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(subscription-service): add billing functionality to subscription… #38

wants to merge 7 commits into from

Conversation

Tyagi-Sunny
Copy link
Contributor

@Tyagi-Sunny Tyagi-Sunny commented Aug 5, 2024 •
edited
Loading

add billing functionality to subscription service

BREAKING CHANGE:
yes

gh-34

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

a-ganguly
a-ganguly approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@a-ganguly a-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add billing functionality to subscription

@Tyagi-Sunny
feat(subscription-service): add billing functionality to subscription…
a505aaa 
… service

add billing functionality to subscription service

BREAKING CHANGE:
yes

gh-34
@yeshamavani yeshamavani mentioned this pull request Sep 27, 2024
Closed
12 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12 New issues
12 New Major Issues (required ≤ 5)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-sourcefuse rohit-sourcefuse rohit-sourcefuse approved these changes

@a-ganguly a-ganguly a-ganguly approved these changes

@yeshamavani yeshamavani Awaiting requested review from yeshamavani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyagi-Sunny @a-ganguly @rohit-sourcefuse