Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Subject, ReplyTo and PartitionKey properties on ServiceBusReceivedMessage creation #19

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Map Subject, ReplyTo and PartitionKey properties on ServiceBusReceivedMessage creation #19

merged 5 commits into from
Sep 30, 2024

Conversation

mickednk
Copy link
Contributor

@mickednk mickednk commented Sep 29, 2024 •
edited
Loading

I added mapping for the Subject property that are the only missing property from the ServiceBusReceivedMessage creation. I use the message subject to identify what the payload contains in my application,

tomas-pajurek
tomas-pajurek requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@tomas-pajurek tomas-pajurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! I have made one minor comment and merged some updates from main that make sure that the GitHub actions runs properly on your PR.

After the comment is resolved, the PR will merge and new version will be released.

src/Spotflow.InMemory.Azure.ServiceBus/Internals/MessagesStore.cs Show resolved Hide resolved
@tomas-pajurek tomas-pajurek changed the title Map Subject property on ServiceBusReceivedMessage creation Map Subject, ReplyTo and PartitionKey properties on ServiceBusReceivedMessage creation Sep 30, 2024
@tomas-pajurek tomas-pajurek enabled auto-merge (squash) September 30, 2024 08:33
@tomas-pajurek tomas-pajurek merged commit 2359540 into spotflow-io:main Sep 30, 2024
5 checks passed
@tomas-pajurek
Copy link
Member

The changes have been released in 0.3.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-pajurek tomas-pajurek tomas-pajurek approved these changes

@DavidNepozitek DavidNepozitek Awaiting requested review from DavidNepozitek DavidNepozitek is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickednk @tomas-pajurek