-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/minmax
#3112
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Can you please tell me why |
"include": [ | ||
"./include" | ||
], | ||
"libraries": [], | ||
"libpath": [], | ||
"dependencies": [ | ||
"@stdlib/math/base/napi/unary", | ||
"@stdlib/math/base/special/minmax" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbhijitRaut04 You don't need to add the "@stdlib/math/base/special/minmax" in the manifest.json
file.
Dependencies in manifest.json
are for external packages or modules that the code relies on.
By listing ./include
in the include path, the manifest.json
specifies that any header files within that directory i.e. minmax.h
are available.
And since, the C implementation of minmax
is not yet implemented listing it in the dependencies is causing the CI errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@headlessNode Removed that dependencies but still not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you run make install-node-addons NODE_ADDONS_PATTERN="math/base/special/minmax"
command on your system?
These are compilation errors, if you run the above command on your system you can get a more verbose
output to pinpoint the source of the errors. Hope it helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. This could be because of how your environment is configured.
@AbhijitRaut04 There are some of inconsistencies in your PR. Namely, the To see what macros are available for you see: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/napi Also, from your lib folder you are missing the I suggest you go through the similar merged PRs to understand how to implement the |
Resolves #2106 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/math/base/special/minmax
#2106Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers