Added favicon size to google provider #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added favicon_size to config file
stefanbauer
requested changes
Oct 21, 2021
config/favicon-extractor.php
Outdated
Comment on lines
4
to
25
| /* | ||
| |-------------------------------------------------------------------------- | ||
| | Favicon Provider | ||
| |-------------------------------------------------------------------------- | ||
| | | ||
| | This value is used for requesting a favicon of the given size (if supported by the given provider) | ||
| | | ||
| */ | ||
|
|
||
| 'favicon_size' => 32, | ||
|
|
||
| /* | ||
| |-------------------------------------------------------------------------- | ||
| | Favicon Provider | ||
| |-------------------------------------------------------------------------- | ||
| | | ||
| | This value is used for requesting a favicon of the given size (if supported by the given provider) | ||
| | | ||
| */ | ||
|
|
||
| 'disk' => 'public', | ||
|
|
There was a problem hiding this comment.
I think it makes sense to put those values below the provider_class configuration with a simple description. It looks weird to me to have duplicate "favicon provider" headlines. The description above the disk is also wrong cause it's just copied from the favicon size.
src/Provider/GoogleProvider.php
Outdated
Comment on lines
21
to
22
| $favicon_size = config('favicon-extractor.favicon_size', 32); | ||
| $size_query = '&sz='.$favicon_size; |
There was a problem hiding this comment.
Variables please in camelCase faviconSize, sizeQuery
Moved config variables between provider and generator
unavatar is interesting because it resolves a domain, username or email to image.
stefanbauer
requested changes
Jun 17, 2022
| private function getUrl(string $url): string | ||
| { | ||
| $faviconSize = config('favicon-extractor.favicon_size', 32); | ||
| $sizeQuery = $faviconSize.'/'; |
There was a problem hiding this comment.
Missing line-break before return
| @@ -18,6 +18,8 @@ public function fetchFromUrl(string $url): string | |||
|
|
|||
| private function getUrl(string $url): string | |||
| { | |||
| return 'https://www.google.com/s2/favicons?domain='.urlencode($url); | |||
| $faviconSize = config('favicon-extractor.favicon_size', 32); | |||
| $sizeQuery = '&sz='.$faviconSize; | |||
There was a problem hiding this comment.
Missing line-break before return
| // size options are limited to 16 & 32 | ||
| $faviconSize = config('favicon-extractor.favicon_size', 32) > 16 ? 32 : 16; | ||
| $sizeQuery = '?size='.$faviconSize; | ||
| return 'https://favicon.yandex.net/favicon/'.urlencode($url).$sizeQuery; |
There was a problem hiding this comment.
Missing line-break before return
|
Sorry for the delay, I missed somehow this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added favicon_size to config file