Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guide for extending a contract instance's ttl #1030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mackenzie-OO7
Copy link
Contributor

closes #616

@briwylde08
Copy link
Contributor

Hey @Mackenzie-OO7! Thanks for your contribution here! The SDF team is currently at a conference so we're a little behind on reviewing PRs but we will get to it when the conference is over.

@Mackenzie-OO7
Copy link
Contributor Author

Hey @Mackenzie-OO7! Thanks for your contribution here! The SDF team is currently at a conference so we're a little behind on reviewing PRs but we will get to it when the conference is over.

No problem!

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, there @Mackenzie-OO7! Thanks for this PR!

There is some conceptual overlap between the page you've written, and an existing page. That one, though, is more focused on how to accomplish this in JavaScript, whereas yours is more "ingrained" in the smart contract itself.

I think it could make sense to combine these into a single page. Maybe that page ends up using the <CodeExample /> component perhaps? That way, you wouldn't have to double-up so much on the conceptual/informational stuff. Whether or not the content actually belongs in the currently published page's location (contract conventions) or here (state archival), I'm not exactly sure, and I think it might even go either way.

What do you think? Is there a way you might be able to weave these two guides together into one?

@Mackenzie-OO7
Copy link
Contributor Author

What do you think? Is there a way you might be able to weave these two guides together into one?

Thanks for reviewing! I think I can do that😅

@Mackenzie-OO7 Mackenzie-OO7 reopened this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a guide for extending a deployed contract instance’s TTL with code
3 participants