Refresh lifecycle CAP #1373
Merged
Refresh lifecycle CAP #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Jul 28, 2023
core/cap-0046-02.md
Outdated
|
|
||
| Every preimage must also include a `networkID` (a hash of the network | ||
| passphrase) which ensures that every network has unique set of contract | ||
| identifiers. | ||
|
|
||
| ### Installing WASM sources using `InvokeHostFunctionOp` |
There was a problem hiding this comment.
nit: Uploading for consistency with op name?
core/cap-0046-02.md
Outdated
| Installed contracts are stored in `ContractCodeEntry` ledger entries. These | ||
| entries are keyed by the hash of `InstallContractCodeArgs` used to install | ||
| Uploaded contracts are stored in `ContractCodeEntry` ledger entries. These | ||
| entries are keyed by the hash of the WASM used to upload |
There was a problem hiding this comment.
nit: Could you please replace 'WASM' with 'Wasm' everywhere in the doc? WASM is not an official spelling, see https://webassembly.org/
core/cap-0046-02.md
Outdated
| @@ -199,29 +157,34 @@ functionality to support them. | |||
| The following host functions are provided to instantiate contracts: | |||
There was a problem hiding this comment.
...to instantiate contracts and upload Wasm:
core/cap-0046-02.md
Outdated
| - Allow specifying a contract ID as the contract's source reference, so that the | ||
| contract would be guaranteed to have exactly the same implementation as the | ||
| referred contract without any additional code. | ||
| control over contracts on the network. The only mechanism they have is disabling |
There was a problem hiding this comment.
I think there are more mechanisms now, as it's possible to limit resources on multiple dimensions (e.g. disable large writes or constrain CPU etc.)
There was a problem hiding this comment.
I removed this section since it no longer applies and probably belongs in a different CAP.
dmkozh
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pass of refreshing the lifecycle CAP.