Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/biome #65

Merged
merged 12 commits into from
Oct 2, 2024
Merged

ci/biome #65

merged 12 commits into from
Oct 2, 2024

Conversation

KinjiKawaguchi
Copy link
Member

  • style: biome
  • ci: install biome
  • refactor
  • refactor
  • format:Forbidden non-null assertion.

@KinjiKawaguchi KinjiKawaguchi changed the base branch from main to develop October 1, 2024 00:49
@KinjiKawaguchi KinjiKawaguchi self-assigned this Oct 1, 2024
KikyoNanakusa
KikyoNanakusa reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@KikyoNanakusa KikyoNanakusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応全部見ました
コードの方は問題ないと思います

github/workflows/code_queality.yaml Outdated
Copy link
Collaborator

@KikyoNanakusa KikyoNanakusa Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ全部のpushとpullrequestで動く想定でいいすか
大変じゃない？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ていうかなんか動いてないよね

@KinjiKawaguchi KinjiKawaguchi merged commit 1b28d8b into develop Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KikyoNanakusa KikyoNanakusa KikyoNanakusa left review comments

Assignees

@KinjiKawaguchi KinjiKawaguchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KinjiKawaguchi @KikyoNanakusa