Automated backport of #2543: Shortening datapath downtime for libreswan cable #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yboaron
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2598/yboaron/automated-backport-of-#2543-origin-release-0.13 |
dfarrell07
approved these changes
Jul 3, 2023
skitt
requested changes
Jul 4, 2023
pkg/cable/libreswan/libreswan.go
Outdated
| if !i.plutoStarted { | ||
| // Ensure Pluto is started | ||
| if err := i.runPluto(); err != nil { | ||
| logger.FatalOnError(err, "Error running Pluto") |
There was a problem hiding this comment.
This isn’t supported on 0.13, you need to use klog.
Currently there is about 2 seconds of downtime in datapath for libreswan cable when the gateway pod restarts. When Pluto starts running [1] the IPsec datapath rules created by the previous GW pod are cleared, and traffic is only recovered after ConnectToEndpoint events are handled by the libreswan cable driver. This PR reduces datapath downtime by: A. Checking Pluto control socket status at faster rate B. Starting Pluto right before the first ConnectToEndpoint event is handled by libreswan cable driver. With this PR, the datapath downtime is reduced to ~0.5 seconds. [1] https://github.com/submariner-io/submariner/blob/devel/pkg/cable/libreswan/libreswan.go#L158 Signed-off-by: Yossi Boaron <yboaron@redhat.com>
yboaron
force-pushed
the
automated-backport-of-#2543-origin-release-0.13
branch
from
beea115
to
dc62215
Compare
nyechiel
approved these changes
Jul 5, 2023
sridhargaddam
approved these changes
Jul 5, 2023
skitt
approved these changes
Jul 10, 2023
|
🤖 Closed branches: [z_pr2598/yboaron/automated-backport-of-#2543-origin-release-0.13] |
dfarrell07
added
the
release-note-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2543 on release-0.13.
#2543: Shortening datapath downtime for libreswan cable
For details on the backport process, see the backport requests page.